Fix default config for RedundantExtendTSig
#138
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original draft, the cop was called `ForbidExtendTSig`. It was later renamed, and the config was moved to what would be the correct location alphabetically, but the actual config key was not updated. This cause the cop to have no default config, so it was enabled by default, which would have been problematic for consumers.
sambostock
commented
Feb 3, 2023
| @@ -501,7 +501,7 @@ end | |||
|
|
|||
| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged | |||
| --- | --- | --- | --- | --- | |||
| Enabled | Yes | Yes | - | - | |||
There was a problem hiding this comment.
This was missed in #131, but should have been a giveaway that something was wrong.
vinistock
approved these changes
Feb 3, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original draft, the cop was called
ForbidExtendTSig. It was later renamed, and the config was moved to what would be the correct location alphabetically, but the actual config key was not updated.This cause the cop to have no default config, so it was enabled by default, which would have been problematic for consumers.