You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sl-input creates two helper inputs to use native input date and number parsing. Inputs are farily heavyweight as far as elements go, and many sl-input instances might never be of type date or number, and so never need or use these helpers.
The helpers should probably be created lazily, and they don't need to be instance properties. One helper can be shared across all sl-input instances.
hmmm...solid point about lazy eval and only constructing 1 instance for all elements. It's a pretty quick change to make as we can move to getters, let me put together a PR real quick and see if anything breaks.
Describe the bug
sl-input creates two helper inputs to use native input date and number parsing. Inputs are farily heavyweight as far as elements go, and many sl-input instances might never be of type date or number, and so never need or use these helpers.
The helpers should probably be created lazily, and they don't need to be instance properties. One helper can be shared across all sl-input instances.
To Reproduce
See
shoelace/src/components/input/input.component.ts
Line 68 in 64996b2
Demo
n/a
Screenshots
n/a
Browser / OS
all
Additional information
n/a
The text was updated successfully, but these errors were encountered: