Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: update for release of PHP 8.2 #673

Merged

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Dec 8, 2022

Description

This PR updates the "PHP support" table in the README.

I also realized that - while not mentioned in the changelog or the readme - PHP 8.3 is already available via the setup-php action runner, so I've added it to the README now.

Ref: https://www.php.net/supported-versions.php

I also realized that - while not mentioned in the changelog or the readme - PHP 8.3 _is_ already available via the `setup-php` action runner, so I've added it to the README now.

Ref: https://www.php.net/supported-versions.php
@jrfnl
Copy link
Contributor Author

jrfnl commented Dec 8, 2022

I realized after I pulled the PR that it may be a good idea to also update the code samples in the README to use 8.2, so I've added a second commit to do just that.

@jrfnl
Copy link
Contributor Author

jrfnl commented Dec 8, 2022

Open question: does latest automatically roll-over to PHP 8.2 now it has been released or does that need to be updated somewhere as well ?

@shivammathur shivammathur merged commit f7d3c00 into shivammathur:develop Dec 8, 2022
@shivammathur
Copy link
Owner

Thanks @jrfnl

@jrfnl
Copy link
Contributor Author

jrfnl commented Dec 8, 2022

Oh and another thing I'm wondering: should the action runner native workflows start including PHP 8.3 ?

@jrfnl jrfnl deleted the feature/readme-update-php-list branch December 8, 2022 14:13
@jrfnl
Copy link
Contributor Author

jrfnl commented Dec 8, 2022

Ha! Just saw your follow-up commit which answered both my questions. Thanks @shivammathur !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants