Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 Bug Fix: make symfony-cli installation faster on Linux #641

Merged
merged 1 commit into from Sep 1, 2022
Merged

Conversation

lmichelin
Copy link
Contributor

@lmichelin lmichelin commented Sep 1, 2022

This PR make symfony-cli installation faster on Linux. Fixes #640.

Brew is available on Ubuntu runners but is very slow. Downloading the binary directly is faster.

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request
  • I have run npm run format before the commit.
  • I have run npm run lint before the commit.
  • I have run npm run release before the commit.
  • npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax.
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link).

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #641 (45410ae) into develop (e04e1d9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop      #641   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          538       538           
  Branches        80        80           
=========================================
  Hits           538       538           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shivammathur shivammathur merged commit 6333217 into shivammathur:develop Sep 1, 2022
@shivammathur
Copy link
Owner

Thanks for the PR. it will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants