Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmlrpc-beta extension stopped working recently #625

Closed
2 of 5 tasks
stronk7 opened this issue Jul 28, 2022 · 6 comments
Closed
2 of 5 tasks

xmlrpc-beta extension stopped working recently #625

stronk7 opened this issue Jul 28, 2022 · 6 comments
Assignees
@shivammathur
Labels
bug Something isn't working

Comments

@stronk7
Copy link

stronk7 commented Jul 28, 2022 •
edited

Describe the bug
Since 24h ago (aprox) we have started to get failures in all our PHP 8.0 jobs. The failure is about the xmlrpc extension not being detected as installed, when we always add it via extensions: xmlrpc-beta.

All jobs were passing until 24h ago and we have verified that all the stack has not changed at all:

  • GH environments version.
  • PECL xmlrpc extensions (RC3 is the latest since months ago).
  • PHP releases
  • ...

And the only piece that has changed is the new release of setup-php 2.21.1.

Version

  • I have checked releases, and the bug exists in the latest patch version of v1 or v2.
  • v2
  • v1

Runners

  • GitHub Hosted
  • Self Hosted

Operating systems
Ubuntu 20.04

PHP versions
PHP 8.0 and PHP 8.1

To Reproduce
I've created this dummy repo with a simple workflow that verifies the "xmlrpc" installation over all PHP versions and, also with php-setup versions 2.20.1 (old) and 2.21.1 (actual). Here it is the workflow:

https://github.com/stronk7/xmlrpc-dummy-test/blob/main/.github/workflows/push.yml

Expected behavior
All the jobs and steps of that workflow should pass, specifically the xmlrpc-beta ones have stopped working.

Screenshots/Logs
You can see the workflow above running @ https://github.com/stronk7/xmlrpc-dummy-test/actions/runs/2755723909

Notes:

  1. PHP 7.2, 7.3 and 7.4 are not affected, they come with xmlrpc bundled.
  2. Curiously "xmlrpc" (without "-beta") is working, I'm near sure it was not in the past.
  3. When using "xmlrpc-beta", fails with setup-php 2.21.1, but passes with setup-php 2.20.1.
  4. The 2.20.1 passing "xmlrpv-beta" runs say xmlrpc-1.0.0 Installed and enabled. I'm not sure from where that 1.0.0 comes. All the other runs, failing or passing just say: xmlrpc Enabled.

Additional context
For us, the fix seems to be easy, just change xmlrpc-beta by xmlrpc and done. Aka, point 2 in the notes above. Just guessing it xmlrpc is going to remain working.

But what seems clear is that xmlrpc-beta has stopped working with last setup-php release (point 3) and that there is something strange around with that 1.0.0 version (that doesn't seem to come from PECL).

Are you willing to submit a PR?
Sorry, I don't have idea about what to fix! For curiosity I looked to the changes between 2.21.0 and 2.21.1... to see if there was something obvious... but no idea.

Ciao :-)
@stronk7 stronk7 added the bug Something isn't working label Jul 28, 2022
stronk7 added a commit to stronk7/moodle that referenced this issue Jul 28, 2022
@stronk7
MDL-xxxxx GHA: Move from xmlrpc-beta to xmlrpc
15f16d0 
For some unknown reason, the installation of the
xmlrpc-beta extension for PHP 8.0 and up is not
working properly with GHA anymore (since July 28, 2022).

Apparently it's installed correctly, but it's not really
there. Because of that the environmental checks are failing
because the extension is not available.

This only affects GHA (not Travis, where xmlrpc-beta, from
PECL continues working ok). Also, it's not expected to
affect moodle-plugin-ci much, because not many plugins
need xmlrpc. No matter of that, an issue will be created
to fix it there.

For reference, this issue has been created, because it seems
that is with the latest updates of the setup-php action
when the problem has started to happen:

shivammathur/setup-php#625
@stronk7 stronk7 mentioned this issue Jul 28, 2022
Closed
@shivammathur
Copy link
Owner

Fixed in 7e03c76. Currently in develop branch right now, will in the next release.

@shivammathur shivammathur added the awaiting-release Added/Fixed and tested, awaiting release label Jul 28, 2022
@stronk7
Copy link
Author

stronk7 commented Jul 28, 2022

Cool, thanks!

Q: and that “mysterious” xmlrpc-1.0.0 that got when using older 2.20.1 was also caused because of the bug?

@shivammathur
Copy link
Owner

Yes, the regex to parse the releases was wrong earlier. it worked because pecl fallbacks to the latest version when a wrong version is specified.

In the previous release I tried to fix this, but only considered the stability in the version. Now it checks for stability in the version (RC in this case), if no version is found matching that, it checks for the pecl stability.

@stronk7
Copy link
Author

stronk7 commented Jul 28, 2022

Aha, thanks for the clarification (and for the quick reply and fix) !

Looking forward the next setup-php release, then, yay!

Ciao :-)

stronk7 added a commit to stronk7/moodle that referenced this issue Jul 29, 2022
@stronk7
MDL-xxxxx GHA: Move from xmlrpc-beta to xmlrpc
c316c2b 
For some unknown reason, the installation of the
xmlrpc-beta extension for PHP 8.0 and up is not
working properly with GHA anymore (since July 28, 2022).

Apparently it's installed correctly, but it's not really
there. Because of that the environmental checks are failing
because the extension is not available.

This only affects GHA (not Travis, where xmlrpc-beta, from
PECL continues working ok). Also, it's not expected to
affect moodle-plugin-ci much, because not many plugins
need xmlrpc. No matter of that, an issue will be created
to fix it there.

For reference, this issue has been created, because it seems
that is with the latest updates of the setup-php action
when the problem has started to happen:

shivammathur/setup-php#625
stronk7 added a commit to stronk7/moodle that referenced this issue Aug 6, 2022
@stronk7
MDL-xxxxx GHA: Move from xmlrpc-beta to xmlrpc
a5f8b83 
For some unknown reason, the installation of the
xmlrpc-beta extension for PHP 8.0 and up is not
working properly with GHA anymore (since July 28, 2022).

Apparently it's installed correctly, but it's not really
there. Because of that the environmental checks are failing
because the extension is not available.

This only affects GHA (not Travis, where xmlrpc-beta, from
PECL continues working ok). Also, it's not expected to
affect moodle-plugin-ci much, because not many plugins
need xmlrpc. No matter of that, an issue will be created
to fix it there.

For reference, this issue has been created, because it seems
that is with the latest updates of the setup-php action
when the problem has started to happen:

shivammathur/setup-php#625
stronk7 added a commit to stronk7/moodle that referenced this issue Aug 12, 2022
@stronk7
MDL-xxxxx GHA: Move from xmlrpc-beta to xmlrpc
2755b79 
For some unknown reason, the installation of the
xmlrpc-beta extension for PHP 8.0 and up is not
working properly with GHA anymore (since July 28, 2022).

Apparently it's installed correctly, but it's not really
there. Because of that the environmental checks are failing
because the extension is not available.

This only affects GHA (not Travis, where xmlrpc-beta, from
PECL continues working ok). Also, it's not expected to
affect moodle-plugin-ci much, because not many plugins
need xmlrpc. No matter of that, an issue will be created
to fix it there.

For reference, this issue has been created, because it seems
that is with the latest updates of the setup-php action
when the problem has started to happen:

shivammathur/setup-php#625
@shivammathur
Copy link
Owner

Released 2.21.2 with the fix.

@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Aug 17, 2022
stronk7 added a commit to stronk7/moodle that referenced this issue Aug 21, 2022
@stronk7
MDL-xxxxx GHA: Move from xmlrpc-beta to xmlrpc
d5f2941 
For some unknown reason, the installation of the
xmlrpc-beta extension for PHP 8.0 and up is not
working properly with GHA anymore (since July 28, 2022).

Apparently it's installed correctly, but it's not really
there. Because of that the environmental checks are failing
because the extension is not available.

This only affects GHA (not Travis, where xmlrpc-beta, from
PECL continues working ok). Also, it's not expected to
affect moodle-plugin-ci much, because not many plugins
need xmlrpc. No matter of that, an issue will be created
to fix it there.

For reference, this issue has been created, because it seems
that is with the latest updates of the setup-php action
when the problem has started to happen:

shivammathur/setup-php#625
@stronk7
Copy link
Author

stronk7 commented Aug 21, 2022

Thanks,

jobs are back to green here, yippee! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivammathur shivammathur

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stronk7 @shivammathur