Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo PHP8.2+gd failure #617

Merged
merged 1 commit into from Jul 13, 2022

Conversation

ChristophWurst
Copy link
Contributor

@ChristophWurst ChristophWurst commented Jul 13, 2022

A Pull Request should be associated with a Discussion.

If you're fixing a bug, adding a new feature or improving something please provide the details in discussions,
so that the development can be pointed in the intended direction.

Related discussion: #616

Further notes in Contribution Guidelines
Thank you for your contribution.

Description

This PR [briefly explain what it does]

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request
  • I have run npm run format before the commit.
  • I have run npm run lint before the commit.
  • I have run npm run release before the commit.
  • npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax.
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link).

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #617 (109db64) into master (3ccc00e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #617   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          538       538           
  Branches        80        80           
=========================================
  Hits           538       538           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ccc00e...109db64. Read the comment docs.

@shivammathur shivammathur changed the base branch from master to develop July 13, 2022 13:46
@shivammathur shivammathur merged commit f3cdc07 into shivammathur:develop Jul 13, 2022
@ChristophWurst ChristophWurst deleted the demo/php82-gd branch July 13, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants