Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Laravel Pint #613

Closed
1 task done
d8vjork opened this issue Jul 11, 2022 · 2 comments
Closed
1 task done

Tools: Laravel Pint #613

d8vjork opened this issue Jul 11, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@d8vjork
Copy link
Contributor

d8vjork commented Jul 11, 2022

Describe the feature

Add Laravel Pint as a tool for those projects that doesn't depend on it or when we don't want to grab dependencies twice (in tests and in code styling check)

The project's URL: https://github.com/laravel/pint

Version

  • I have checked releases, and the feature is missing in the latest patch version of v2.

Are you willing to submit a PR?

Yes, when I've time to spent today or during this week I'll look at this

@d8vjork d8vjork added the enhancement New feature or request label Jul 11, 2022
@shivammathur shivammathur added the awaiting-release Added/Fixed and tested, awaiting release label Jul 11, 2022
@shivammathur
Copy link
Owner

Released in 2.21.0.

@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Jul 19, 2022
@Akecel
Copy link

Akecel commented Sep 19, 2022

Hello ! @d8vjork @shivammathur
Thank you very much for this addition which saves my life ahah. Unfortunately I have a little problem with the setup of this tool.

I hesitated to create a new issue but I prefer to ask here first because I'm sure it's a stupid mistake on my part but if needed I could create an issue if it's a real bug.

I don't think I missed anything but the setup doesn't seem to work :/

Any idea ? Thanks in advance

      - name: Setup PHP
        uses: shivammathur/setup-php@v2
        with:
          php-version: '8.0'
          tools: pint
      - name: Run Laravel Pint without Fix
        run: pint --test

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants