Always install additional extension libs when given

[ruudk]

I see that setup-php can automatically install additional libs.

But it appears that this is only picked up when building from source.

Right now, I'm trying to install https://pecl.php.net/package-info.php?package=memcached&version=3.2.0RC2 from PECL and that fails because it needs libmemcached-dev.

I provided this:

            -   name: Setup PHP
                uses: shivammathur/setup-php@verbose
                with:
                    php-version: '8.1'
                    coverage: none
                    extensions: memcached-3.2.0RC2
                env:
                    fail-fast: true
                    MEMCACHED_LIBS: zlib1g-dev libmemcached-dev

It would be great if the same trick works for PECL packages as well.

I solved it by running sudo apt-get install -y libmemcached-dev before this step.

[shivammathur]

Added support in e9884d0
Will be in the next release.

Test workflow: https://github.com/shivammathur/test-setup-php/actions/runs/1960085437/workflow

[ruudk]

@shivammathur Thank you so much! Any ETA for that release?

[shivammathur]

@ruudk I was very busy last week. Will try to do it tomorrow.

[shivammathur]

Released 2.18.0 with support.
Docs: https://github.com/shivammathur/setup-php/wiki/Add-extension-from-PECL-with-libraries-and-custom-configuration

[ruudk]

I just tested it and it works great:

            -   name: Setup PHP
                uses: shivammathur/setup-php@verbose
                with:
                    php-version: '8.1'
                    coverage: none
                    extensions: memcached-3.2.0RC2
                env:
                    fail-fast: true
                    MEMCACHED_LIBS: zlib1g-dev libmemcached-dev
# ✓ memcached-3.2.0RC2 Installed and enabled with libraries libmemcached-dev zlib1g-dev

but when I do the same for rdkafka it does not:

            -   name: Setup PHP
                uses: shivammathur/setup-php@verbose
                with:
                    php-version: '8.1'
                    coverage: none
                    extensions: rdkafka
                env:
                    fail-fast: true
                    RDKAFKA_LIBS: librdkafka-dev

# ✗ rdkafka Could not install rdkafka on PHP 8.1.3

Could it be that the *_LIBS are skipped when no version is specified?

[ruudk]

For rdkafka (even the pecl version), you always need to install librdkafka-dev so using it without is impossible.

[shivammathur]

@ruudk

Patched, it should work now.
For now, the logs in v2 will just say "installed and enabled", in the next release I will try to improve the logs to mention the libraries as well.

[ruudk]

@shivammathur It works 👏 Thanks 💙