Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action breaks actions/setup-node #562

Closed
2 of 5 tasks
martijngastkemper opened this issue Feb 8, 2022 · 2 comments
Closed
2 of 5 tasks

Action breaks actions/setup-node #562

martijngastkemper opened this issue Feb 8, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@martijngastkemper
Copy link

martijngastkemper commented Feb 8, 2022

Describe the bug
When installing PHP after installing Node the previously installed Node version isn't available anymore.

Version

  • I have checked releases, and the bug exists in the latest patch version of v1 or v2.
  • v2
  • v1

Runners

  • GitHub Hosted
  • Self Hosted

Operating systems
Ubuntu 18.04

PHP versions
I've tested 7.4 and 8.1.

To Reproduce

This workflow echo's version 16, the default Node version of Ubuntu 18.04

on:
  push:

jobs:
  test:
    runs-on: ubuntu-18.04
    steps:
      - uses: actions/setup-node@v2
        with:
          node-version: "10"
      - uses: shivammathur/setup-php@v2
      - run: node --version

Expected behavior
This workflow echo's version 10, the version installed by actions/setup-node:

on:
  push:

jobs:
  test:
    runs-on: ubuntu-18.04
    steps:
      - uses: shivammathur/setup-php@v2
      - uses: actions/setup-node@v2
        with:
          node-version: "10"
      - run: node --version

Screenshots/Logs

Wrong output:

Screenshot 2022-02-08 at 19 06 02

Correct output:

Screenshot 2022-02-08 at 19 07 22

Are you willing to submit a PR?

I'm willing to do that, but it will take me some time to dive into the source.

@martijngastkemper martijngastkemper added the bug Something isn't working label Feb 8, 2022
@shivammathur
Copy link
Owner

@martijngastkemper
Copy link
Author

martijngastkemper commented Feb 9, 2022

The issue is fixed. Thanks for the quick action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants