Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default xdebug version #345

Closed
GrahamCampbell opened this issue Nov 26, 2020 · 8 comments
Closed

Default xdebug version #345

GrahamCampbell opened this issue Nov 26, 2020 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@GrahamCampbell
Copy link
Contributor

I think xdebug 3 should be the default on PHP 7.3 or higher (but not 7.2, because it doesn't work with the latest version of phpunit which still supports PHP 7.2).

@GrahamCampbell GrahamCampbell added the bug Something isn't working label Nov 26, 2020
@shivammathur

This comment has been minimized.

@GrahamCampbell

This comment has been minimized.

@GrahamCampbell

This comment has been minimized.

@GrahamCampbell

This comment has been minimized.

@shivammathur shivammathur mentioned this issue Nov 26, 2020
@shivammathur
Copy link
Owner

@GrahamCampbell After 2.9.0, it should setup Xdebug 2.9.8 on PHP 7.2.
Please test and let me know

@GrahamCampbell
Copy link
Contributor Author

PHPUnit 8.5 has now been patched to work with Xdebug 3.0. I don't know if we want to change the default back to 3.0.0, or leave it on 2.9.8, since PHPUnit 7.5 still won't work properly.

@shivammathur
Copy link
Owner

shivammathur commented Nov 27, 2020

Will test this before next release and if it is working on PHP 7.2, I will remove the workaround I added to setup Xdebug 2.

The php7.2-xdebug version on the ubuntu runner will anyway change to Xdebug 3 once it is updated on the PPA. Then the workaround will add 30-40 sec to the runtime for everyone on PHP 7.2, if not removed. Instead I will add a coverage: xdebug2 option for PHPUnit 7 users.

@GrahamCampbell
Copy link
Contributor Author

Cool. :)

@shivammathur shivammathur pinned this issue Nov 30, 2020
@shivammathur shivammathur unpinned this issue Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants