Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.8.0 #337

Merged
merged 25 commits into from Nov 17, 2020
Merged

2.8.0 #337

merged 25 commits into from Nov 17, 2020

Conversation

shivammathur
Copy link
Owner

@shivammathur shivammathur commented Nov 17, 2020

  • Add support to setup a specific Composer version.
    For example to setup Composer 2.0.6.
- name: Setup PHP
  uses: shivammathur/setup-php@v2
  with:
    php-version: '7.4'
    tools: composer: 2.0.6
  • Add support for couchbase extension for PHP 5.6 to PHP 7.4.
- name: Setup PHP
  uses: shivammathur/setup-php@v2
  with:
    php-version: '7.4'
    extensions: couchbase
  • Set blackfire-player to v1.9.3 for PHP 5.5 to PHP 7.0.
  • Set composer version to v1 when prestissimo or composer-prefetcher is specified in tools. It is recommended to stop using prestissimo as Composer 2 is faster on its own.
  • Document using setup-php on i386 and amd64 containers using spc. Docs. Closes 32 bits builds of PHP #326.
  • Add workflow to document extensions that are enabled by default on wiki. (Document default extensions #327)
  • Fix tools setup when latest release does not have the tool in release assets. Will now fetch tool from the previous release till it is added to the latest release.
  • Improve regex for pre-release PECL extensions. (sqlsrv Could not install sqlsrv-5.9.0preview1 #325)
  • Install VcRedist from GitHub on Windows.
  • Update PHP dependencies as per GitHub Action runner version on macOS.
  • Fix grpc_php_plugin setup. Now uses Xcode 11.7 as compiling it with Xcode 12 is flaky.
  • Fix extension setup on PHP 8.0 and PHP 8.1 and for all PHP versions on self-hosted Linux.
  • Fix composer setup when it is a dependency of a tool.
  • Revert back to apt-fast as after 1.9.10 release it reports correct exit codes.
  • Revert back to using dashes in step-ids as issue parsing them is fixed upstream (Rewrite contexts before evaluating them nektos/act#287).
  • Use GitHub releases(s3) as primary source for builds and scripts with bintray only as fallback. This will scale setup-php better and avoid bintray's 2TB/month download limit.
  • Refactor and dry linux.sh and darwin.sh.
  • Fix contribution docs.
  • Bump version to 2.8.0.

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #337 (dd72213) into master (3c0527b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #337   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          486       484    -2     
=========================================
- Hits           486       484    -2     
Impacted Files Coverage Δ
src/extensions.ts 100.00% <100.00%> (ø)
src/tools.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0527b...dd72213. Read the comment docs.

@shivammathur shivammathur merged commit 4a10c3b into master Nov 17, 2020
shivammathur added a commit that referenced this pull request Nov 17, 2020
shivammathur added a commit that referenced this pull request Nov 20, 2020
shivammathur added a commit that referenced this pull request Nov 20, 2020
fabpot added a commit to symfony/symfony that referenced this pull request Nov 21, 2020
This PR was merged into the 5.1 branch.

Discussion
----------

[Cache] Fix CI because of Couchbase version

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

It looks likes the version 3.0 of the couchbase extension does not exposes the `\CouchbaseCluster` class anymore.
I didn't find documentaiton about the BC break, but their documentation changes
version 2.6 => https://docs.couchbase.com/php-sdk/2.6/managing-connections.html
version 3.0 => https://docs.couchbase.com/php-sdk/current/howtos/managing-connections.html

It wasn't reported before, because `shivammathur/setup-php` added the extension 3days ago shivammathur/setup-php#337

Sounds like the adapter were never tested, because the extension where missing and phpunit skipped the tests.

Commits
-------

fcbf0bf Display debug info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

32 bits builds of PHP
3 participants