Skip to content

Download release assets for PowerShell PhpManager #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Download release assets for PowerShell PhpManager #279

merged 1 commit into from
Aug 25, 2020

Conversation

mlocati
Copy link
Contributor

@mlocati mlocati commented Aug 25, 2020

I just updated the PowerShell release script: now it builds an asset for every release.

Downloading such assets is preferable since:

  • they contain updated metadata (useful for debugging)
  • they contain only the production files
  • they are pre-built: GitHub doesn't have to create a ZIP from a tag

Verified

This commit was signed with the committer’s verified signature.
mlocati Michele Locati
Downloading such assets is preferable since:
- they contain updated metadata (useful for debugging)
- they contain only the production files
- they are pre-built: GitHub doesn't have to create a ZIP from a tag
@mlocati
Copy link
Contributor Author

mlocati commented Aug 25, 2020

PS: having such assets is guaranteed by the release process of PhpManager.

Indeed, when I create a new release, I only have to push a new tag to the repository, where a script automatically does the following:

  1. updates the module metadata
  2. creates an asset containing the PowerShell module
  3. publishes the new release to PowerShell Gallery
  4. creates a GitHub release as draft, so that it's not counted when fetching api.github.com/repos/mlocati/powershell-phpmanager/releases/latest
  5. attaches the asset to this draft release
  6. marks the release as not draft (so that it's the latest one)

@shivammathur shivammathur merged commit 215cedd into shivammathur:develop Aug 25, 2020
@mlocati mlocati deleted the win32/use-powershell-phpmanager-release-assets branch August 25, 2020 17:58
shivammathur added a commit that referenced this pull request Sep 6, 2020

Verified

This commit was signed with the committer’s verified signature.
shivammathur Shivam Mathur
…release-assets

Download release assets for PowerShell PhpManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants