Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios][disk] IOKit is not available on iOS #1362

Merged
merged 1 commit into from Nov 19, 2022
Merged

Conversation

tmm1
Copy link
Contributor

@tmm1 tmm1 commented Oct 11, 2022

fix iOS builds with cgo trying to build with IOKit

@shirou
Copy link
Owner

shirou commented Oct 19, 2022

Thank you! I don't know iOS, but IOKit is available on iOS 16.0?

@tmm1
Copy link
Contributor Author

tmm1 commented Nov 1, 2022

You're right, they include part of IOKit on iOS now.

But the actual drive stats are still macOS only:

https://developer.apple.com/documentation/iokit/kioblockstoragedriverstatisticslatentwritetimekey/

{kIOBlockStorageDriverStatisticsLatentWriteTimeKey, offsetof(DriveStats, writelat)},

Same with the properties:

https://developer.apple.com/documentation/iokit/kiobsdnamekey/

name = (CFStringRef)CFDictionaryGetValue(props, CFSTR(kIOBSDNameKey));

@tmm1
Copy link
Contributor Author

tmm1 commented Nov 18, 2022

@shirou wdyt?

Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have iOS devices. If it is not possible to build, I would consider this change does not break compatibility. If it breaks, someone will open an issue. so I merge this. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants