Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(disk): correctly replace /dev in /dev/mapper #1412

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Feb 1, 2023

Only replace the first instance of /dev in a /dev/mapper string. Otherwise, if an LVM group is named dev it will replace that as well.

fixes: #1411

Only replace the first instance of /dev in a /dev/mapper string.
Otherwise, if an LVM group is named dev it will replace that as well.

fixes: #1411
@powersj
Copy link
Contributor Author

powersj commented Feb 13, 2023

@shirou anything I can do to help this along?

Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Thank you for pointing out, good catch!

(sorry I am late because I can only do gopsutil work on weekends.)

@shirou shirou merged commit b51f72e into shirou:master Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lvm group named dev fails to resolve
2 participants