Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retract deleted tag v3.22.11 #1386

Merged
merged 1 commit into from Dec 2, 2022
Merged

Retract deleted tag v3.22.11 #1386

merged 1 commit into from Dec 2, 2022

Conversation

bogdandrutu
Copy link
Contributor

@bogdandrutu bogdandrutu commented Dec 1, 2022

This is to disallow to re-tag v3.22.11 since you will generate security issues/warnings (different checksum)

@hansgylling
Copy link

Is the subject of this PR supposed to say "Retract deleted tag v3.22.11"? It's v3.22.11 that's retracted in the PR, not v3.22.10. Also tag v3.22.10 is still there, it's not deleted.

@shirou
Copy link
Owner

shirou commented Dec 2, 2022

Ah, sorry, I was not aware of the impact of this deletion.

The background is, I have merged #1384 yesterday, but test failed (That test was success when before merged). And v3.22.11 was tagged automatically while merged. So I have removed the v3.22.11 tag because it might be affected by the failure of this test.

I agree with making it "retracted", v3.22.11, not v3.22.10.

@bogdandrutu bogdandrutu changed the title Retract deleted tag v3.22.10 Retract deleted tag v3.22.11 Dec 2, 2022
@bogdandrutu
Copy link
Contributor Author

@shirou fixed the title, sorry.. the go.mod is fine

Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you so much!

@shirou shirou merged commit 3b918eb into shirou:master Dec 2, 2022
@bogdandrutu bogdandrutu deleted the patch-1 branch December 2, 2022 15:40
@bogdandrutu bogdandrutu restored the patch-1 branch December 2, 2022 15:40
@bogdandrutu bogdandrutu deleted the patch-1 branch December 2, 2022 15:40
tklauser added a commit to google/gops that referenced this pull request Dec 14, 2022
dependabot updated gopsutil to v3.22.11 in PR #189. That tag is no
longer available upstream and was retracted, see shirou/gopsutil#1386.
Switch back to the previous version for now and let dependabot update
once there is a new version.

Fixes #191
tklauser added a commit to google/gops that referenced this pull request Dec 14, 2022
dependabot updated gopsutil to v3.22.11 in PR #189. That tag is no
longer available upstream and was retracted, see shirou/gopsutil#1386.
Switch back to the previous version for now and let dependabot update
once there is a new version.

Fixes #191
tklauser added a commit to google/gops that referenced this pull request Dec 15, 2022
dependabot updated gopsutil to v3.22.11 in PR #189. That tag is no
longer available upstream and was retracted, see shirou/gopsutil#1386.
Switch back to the previous version for now and let dependabot update
once there is a new version.

Fixes #191
@shirou shirou mentioned this pull request Dec 17, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants