Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[disk][linux] Fix for diskusage Ceph mount #1345

Merged
merged 4 commits into from Sep 9, 2022
Merged

[disk][linux] Fix for diskusage Ceph mount #1345

merged 4 commits into from Sep 9, 2022

Conversation

itsties
Copy link
Contributor

@itsties itsties commented Aug 25, 2022

This sets used and usedPercent correctly in #1344

@itsties
Fix for diskusage Ceph mount
43d805c 
This sets `used` and `usedPercent` correctly in shirou#1344
@itsties itsties changed the title Fix for diskusage Ceph mount [disk][linux] Fix for diskusage Ceph mount Aug 25, 2022
@itsties
Copy link
Contributor Author

itsties commented Sep 1, 2022

i changed f253d81 and e4409ef for the lint error in the previous pull request 705a63f

shirou
shirou approved these changes Sep 9, 2022
View reviewed changes
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. The problem is Files and Ffree in Statfs are sometimes corrupted. I agree to even those fields are corrupted, we can add other fields. So totally agree to this PR. Thank you so much!

@shirou shirou merged commit 434cc29 into shirou:master Sep 9, 2022
@itsties itsties deleted the patch-1 branch September 12, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirou shirou shirou approved these changes

Assignees
No one assigned
Labels
package:disk package:net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itsties @shirou