Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[disk][freebsd] include serial number in IOCounters #1254

Merged
merged 1 commit into from Feb 24, 2022
Merged

[disk][freebsd] include serial number in IOCounters #1254

merged 1 commit into from Feb 24, 2022

Conversation

scop
Copy link
Contributor

@scop scop commented Feb 22, 2022

No description provided.

shirou
shirou approved these changes Feb 24, 2022
View reviewed changes
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you. (I agree about we can ignore the error return value in this case)

@shirou shirou merged commit b47e88a into shirou:master Feb 24, 2022
@scop scop deleted the fix/freebsd-iocounters-disk-serial branch February 25, 2022 08:17
@scop
Copy link
Contributor Author

scop commented Feb 25, 2022

I also agree that it's ok to ignore the error here. But for full disclosure, doing that wasn't my invention, I just followed what was already being done in the corresponding Linux version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirou shirou shirou approved these changes

Assignees
No one assigned
Labels
package:disk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scop @shirou