Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable contextcheck linter #1210

Merged
merged 2 commits into from Feb 24, 2022
Merged

enable contextcheck linter #1210

merged 2 commits into from Feb 24, 2022

Conversation

mmorel-35
Copy link
Contributor

I didn't know this linter exists. It has restored the context as a parameter for some functions and add it to some.

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #1210 (6e37208) into master (2f8da0a) will increase coverage by 0.18%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
+ Coverage   44.75%   44.93%   +0.18%     
==========================================
  Files          51       51              
  Lines        8058     8058              
==========================================
+ Hits         3606     3621      +15     
+ Misses       3997     3984      -13     
+ Partials      455      453       -2     
Flag Coverage Δ
Linux 40.25% <61.53%> (-0.13%) ⬇️
Windows 41.17% <100.00%> (+0.56%) ⬆️
go-1.16.x 44.89% <61.53%> (+0.14%) ⬆️
go-1.17.x 44.93% <61.53%> (+0.21%) ⬆️
macOS 43.58% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/common/common_linux.go 0.00% <0.00%> (ø)
net/net_linux.go 38.80% <43.75%> (-0.37%) ⬇️
docker/docker_linux.go 19.35% <66.66%> (-1.85%) ⬇️
process/process_linux.go 54.27% <71.42%> (ø)
cpu/cpu.go 67.36% <100.00%> (ø)
process/process_darwin.go 57.18% <0.00%> (+0.89%) ⬆️
process/process_windows.go 59.45% <0.00%> (+0.94%) ⬆️
process/process_windows_amd64.go 87.75% <0.00%> (+2.04%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f8da0a...6e37208. Read the comment docs.

@mmorel-35 mmorel-35 marked this pull request as draft January 22, 2022 18:07
@mmorel-35 mmorel-35 marked this pull request as ready for review January 23, 2022 08:54
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late response. This seems great. Thank you for your contribution!

@shirou shirou merged commit 9a667f1 into shirou:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants