Add additional process states #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirou
approved these changes
Nov 28, 2021
There was a problem hiding this comment.
Great! Unfortunately, this function is used by only Linux and Darwin. Others like FreeBSD converts from kproc directly. But this PR provides room for extensions to FreeBSD and OpenBSD, and does not break compatibility. So LGTM! Thank you so much!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the move from v1 to v3, process states has changed from returning a single character for status to an enum. https://github.com/open-telemetry/opentelemetry-collector was depending on some of these states.
I've looked through the documentation for most platforms and ensured that we are capturing all the cases (FreeBSD, OpenBSD, Linux, Solaris, Darwin).
See tracking issue: #1171