Fixes for Test_Connections in process_linux.go #1119
Conversation
tbarker25
force-pushed
the
process-fixes-1
branch
from
2e7c002
to
d68bd66
Compare
|
These changes also need to be applied in the v3 modules. Commits history needs some love, the first one would be "Fix Test_Connections in process_linux.go" (only including changes to the Test_Connections function) with body the first part of your message in the PR and the proper connections closing bit, second commit would be about the various other fixes, with its body the rest of this PR message (or a separate commit for each point). LGTM otherwise, tests are all green |
tbarker25
force-pushed
the
process-fixes-1
branch
2 times, most recently
from
12dfbb6
to
79896a1
Compare
other OSs), and fails consistently if run with `go test -times=N` On inspection, Go closes TCP connections when they go out of scope and are garbage collected. I've re-written Test_Connections() to explicitly close connectections once the test has finished. This has the other benefit of closing gracefully, which means the -times argument should work. I've also removed the t.Skip() calls inside goroutines as they are unsupported.
tbarker25
force-pushed
the
process-fixes-1
branch
from
79896a1
to
bc46619
Compare
Thanks. I've made those changes. |
|
Sorry to late response. Thank you so much! |
Test_Connections currently fails intermittently on Linux (and maybe other OSs).
On inspection, Go closes TCP connections when they go out of scope and are garbage collected. I've re-written Test_Connections() to avoid closing until the test has finished.
Other changes:
go test -times=Nworks