-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wmi version #1099
fix wmi version #1099
Conversation
On my environment, there are no errors on current master branch. After patching this PR, I got this error.
After |
So I cleared out all of my go caches and re-verified everything and the current hashes do appear to be correct. When WMI 1.2.0 was released the wrong commit was very briefly pointing at the wrong commit... maybe it's possible that's the cause? I'll open an issue to see if he can just do a new v1.2.1 tag/release and hopefully that will solve this. |
I believe @lespea is correct and that this is what I was referring to about the tag being changed: StackExchange/wmi#58 (comment) In general, it's poor form to relocate a tag in a public repository, and this issue originates from precisely that being done in the WMI repository. It leads to scenarios like this where developer A with the original tag in their cache (shirou) has no problems, but developer B without it (me, Dependabot) cannot download the dependency, since the go.sum refers to a different commit than the one that is now tagged on the remote. @shirou You will probably be able to reproduce the issue by installing to a 'clean' machine or, if you don't mind wiping your cache, executing Unfortunately, the only 'good' way to fix this is for WMI to receive a new and completely unambiguous tag v1.2.1 - so, @lespea is correct again by raising the issue there. gopsutil can then be updated to use that tag and resolve the conflict 👍 |
One note - I am installing |
After (I am really not a fan of current golang mod system). |
The dependabot works. Great work! |
However, some of tests are failing. perhaps caches in github actions. |
Might have to wait for a new tag to be pushed for wmi :/ Sorry this turned into such a headache. |
Yeah. Sorry! |
It seems like the StackExchange/wmi tag was changed after being installed to this repo, and it's caused us major problems trying to use the latest gopsutil:
This PR redownloads dependencies so the tag actually matches the commit again.