Add missing TargetConditionals.h include, closes #976 #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fairly certain that the test failure on macos 10.12 (EOL 2019-11-30) is not due to this change: |
|
I don't have a Mac but it seems TargetConditionals.h has Thank you for your contribution! |
5 tasks
aashishkapur
pushed a commit
to aashishkapur/lightstep-tracer-go
that referenced
this pull request
May 19, 2022
I'm getting the following warning when building a package depending on lightstep-tracer-go: ../../pkg/mod/github.com/shirou/gopsutil/v3@v3.21.2/cpu/cpu_darwin_cgo.go:13:5: warning: 'TARGET_OS_MAC' is not defined, evaluates to 0 [-Wundef-prefix=TARGET_OS_] We can fix this by upgrading gopsutil, see shirou/gopsutil#1042
aashishkapur
pushed a commit
to aashishkapur/lightstep-tracer-go
that referenced
this pull request
May 20, 2022
I'm getting the following warning when building a package depending on lightstep-tracer-go: ../../pkg/mod/github.com/shirou/gopsutil/v3@v3.21.2/cpu/cpu_darwin_cgo.go:13:5: warning: 'TARGET_OS_MAC' is not defined, evaluates to 0 [-Wundef-prefix=TARGET_OS_] We can fix this by upgrading gopsutil, see shirou/gopsutil#1042
codeboten
pushed a commit
to lightstep/lightstep-tracer-go
that referenced
this pull request
May 31, 2022
I'm getting the following warning when building a package depending on lightstep-tracer-go: ../../pkg/mod/github.com/shirou/gopsutil/v3@v3.21.2/cpu/cpu_darwin_cgo.go:13:5: warning: 'TARGET_OS_MAC' is not defined, evaluates to 0 [-Wundef-prefix=TARGET_OS_] We can fix this by upgrading gopsutil, see shirou/gopsutil#1042
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.