Fixes #1026 windows counters on non english systems #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirou
reviewed
Feb 6, 2021
| @@ -72,6 +72,7 @@ var ( | |||
|
|
|||
| PdhOpenQuery = ModPdh.NewProc("PdhOpenQuery") | |||
| PdhAddCounter = ModPdh.NewProc("PdhAddCounterW") | |||
| PdhAddEnglishCounterW = ModPdh.NewProc("PdhAddEnglishCounterW") | |||
There was a problem hiding this comment.
Could you delete PdhAddCounter? Now it is unused.
|
Sorry, could you make a commit to v2 also? |
|
Done. I now rembered. The error message was just: "gopsutil: unexpected processor queue length counter error, please file an issue on github". This is why I've added the err to the log message. |
|
Sorry, one more. Could you delete https://github.com/shirou/gopsutil/pull/1027/files#r571389523 |
|
Done |
|
Great! Thank you for your contribution! |
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1026