From 839e8b731f3d89f5028e6bff65625ab3d914be9a Mon Sep 17 00:00:00 2001 From: shirou Date: Tue, 19 Jul 2022 12:43:41 +0000 Subject: [PATCH] fix(common): simplify size check --- internal/common/common.go | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/internal/common/common.go b/internal/common/common.go index 15872a8fa..adc4922bd 100644 --- a/internal/common/common.go +++ b/internal/common/common.go @@ -313,19 +313,11 @@ func PathExists(filename string) bool { // PathExistsWithContents returns the filename exists and it is not empty func PathExistsWithContents(filename string) bool { - if _, err := os.Stat(filename); err != nil { - return false - } - - f, err := os.Open(filename) + info, err := os.Stat(filename) if err != nil { return false } - defer f.Close() - - r := bufio.NewReader(f) - _, err = r.Peek(4) // check first 4 bytes - return err == nil + return info.Size() > 4 // at least 4 bytes } // GetEnv retrieves the environment variable key. If it does not exist it returns the default.