Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide user control over pod label #625

Open
SaschaSchwarze0 opened this issue Feb 26, 2021 · 5 comments · May be fixed by #1069
Open

Provide user control over pod label #625

SaschaSchwarze0 opened this issue Feb 26, 2021 · 5 comments · May be fixed by #1069

Comments

@SaschaSchwarze0
Copy link
Member

Labels in Kubernetes are meant to be identifying attributes for the user, see here. As of today, a user can specify labels on all our objects for example to categorize them and to later search for them using this label.

But, we are not propagating these labels further to the TaskRun or Pod. There, we only set a set of hard-coded labels including the BuildRun, Build and BuildStrategy names. For a user, it might make sense to see his labels also on the TaskRun and Pod objects to filter them based on his own categorization.
@SaschaSchwarze0 SaschaSchwarze0 mentioned this issue Feb 26, 2021
Closed
@gabemontero
Copy link
Member

implementation wise there could be some overlap with #50 even if the scenarios / goals are not the same

@Pinolo
Copy link

Pinolo commented May 10, 2022

I'd like to pick this issue as first-time contribution. I'll come back with some draft code in the next few days

@SaschaSchwarze0
Copy link
Member Author

I'd like to pick this issue as first-time contribution. I'll come back with some draft code in the next few days

Thanks @Pinolo, you can also have a look at our good-first-issue project to find issues that we assessed to be a good start.

@Pinolo
Copy link

Pinolo commented May 16, 2022

EP created: shipwright-io/community#86

@Pinolo Pinolo linked a pull request May 24, 2022 that will close this issue
Open
4 tasks
@Pinolo
Copy link

Pinolo commented May 24, 2022

My colleague @alessiopiazza and me put together a draft implementation. We know it doesn't look pretty, but we didn't feel like going for a refactoring without prior discussion. Waiting for feedback on the EP, too

@binnn6 binnn6 mentioned this issue Nov 11, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

625 user control over pod labels Pinolo/shipwright-build
3 participants
@Pinolo @gabemontero @SaschaSchwarze0