From a8506056fb46ce8092be5aa7ae7ba970983469f6 Mon Sep 17 00:00:00 2001 From: Suyan Date: Thu, 8 Dec 2022 08:52:11 +0800 Subject: [PATCH] fix(#3233): fix rendering 0 when there are no errors. (#3234) * fix(#3233): fix rendering 0 when there are no errors. * fix: update snapshot and changelog * fix: update snapshot Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com> --- CHANGELOG.md | 3 +++ packages/antd/src/templates/FieldTemplate/index.tsx | 2 +- packages/antd/test/__snapshots__/Array.test.tsx.snap | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3c8452c0ce..56780b1873 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,6 +34,9 @@ should change the heading of the (upcoming) version to include a major version b - For JSON Schemas with `$id`s, use a pre-compiled Ajv validation function when available. - No longer fail to validate inner schemas with `$id`s, fixing [#2821](https://github.com/rjsf-team/react-jsonschema-form/issues/2181). +## @rjsf/antd +- No longer render extra 0 for array without errors, fixing [#3233](https://github.com/rjsf-team/react-jsonschema-form/issues/3233) + # 5.0.0-beta.12 ## @rjsf/antd diff --git a/packages/antd/src/templates/FieldTemplate/index.tsx b/packages/antd/src/templates/FieldTemplate/index.tsx index 87d8800619..3d2d98fb92 100644 --- a/packages/antd/src/templates/FieldTemplate/index.tsx +++ b/packages/antd/src/templates/FieldTemplate/index.tsx @@ -69,7 +69,7 @@ const FieldTemplate = ({ colon={colon} extra={rawDescription && description} hasFeedback={schema.type !== "array" && schema.type !== "object"} - help={(!!rawHelp && help) || (rawErrors?.length && errors)} + help={(!!rawHelp && help) || (rawErrors?.length ? errors : undefined)} htmlFor={id} label={displayLabel && label} labelCol={labelCol} diff --git a/packages/antd/test/__snapshots__/Array.test.tsx.snap b/packages/antd/test/__snapshots__/Array.test.tsx.snap index 40513b922b..1bb419e642 100644 --- a/packages/antd/test/__snapshots__/Array.test.tsx.snap +++ b/packages/antd/test/__snapshots__/Array.test.tsx.snap @@ -745,7 +745,7 @@ exports[`array fields empty errors array 1`] = ` className="form-group field field-string" >