Add an ensure_whatever macro.
#330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a combination of `ensure` and `whatever`. Closes #328
✅ Deploy Preview for shepmaster-snafu ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
8573
reviewed
May 1, 2022
| /// fn get_bank_account_balance(account_id: &str) -> Result<u8> { | ||
| /// # fn moon_is_rising() -> bool { false } | ||
| /// ensure_whatever!( | ||
| /// moon_is_rising(), |
There was a problem hiding this comment.
Was it intended to negate the condition? If I'm not mistaken, this changes it from if moon_is_rising() to (after macro expansion) if !moon_is_rising().
There was a problem hiding this comment.
Not intended, per se, but I’m ok with it. Since it’s just an example, whatever shows the feature easiest is a good choice, IMO. I don’t expect anyone will remember the example from one version to the next 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combination of
ensureandwhatever.Closes #328