Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors stabilized in 1.34 to the core Error shims #327

Merged
merged 1 commit into from May 1, 2022

Conversation

shepmaster
Copy link
Owner

Fixes #324

@shepmaster shepmaster added the bug Something isn't working label Feb 6, 2022
@netlify
Copy link

netlify bot commented Feb 6, 2022

✔️ Deploy Preview for shepmaster-snafu ready!

🔨 Explore the source changes: 76c02d8

🔍 Inspect the deploy log: https://app.netlify.com/sites/shepmaster-snafu/deploys/6216f0b87782c00008cdf840

😎 Browse the preview: https://deploy-preview-327--shepmaster-snafu.netlify.app

@FedericoPonzi
Copy link

FedericoPonzi commented Feb 22, 2022

Thanks a lot for the quick pr! Unfortunately I cannot test it because it's not building, I'm getting the same error from the CI

error: no rules expected the token `core`
  --> src/no_std_error.rs:37:5
   |
17 | macro_rules! impl_error {
   | ----------------------- when calling this macro
...
37 |     core::array::TryFromSliceError, // 1.34
   |     ^^^^ no rules expected this token in macro call

error: could not compile `snafu` due to previous error

Exit status: 101

src/no_std_error.rs Outdated Show resolved Hide resolved
src/no_std_error.rs Outdated Show resolved Hide resolved
@shepmaster
Copy link
Owner Author

because it's not building

Well, that's embarrassing. Let's try that again.

@shepmaster shepmaster merged commit 171a3cf into main May 1, 2022
@shepmaster shepmaster deleted the msrv-core-errors branch May 1, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TryFromIntError in no-std
2 participants