Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use console.debug when available #13

Merged
merged 1 commit into from Apr 13, 2020

Conversation

RazerM
Copy link
Contributor

@RazerM RazerM commented Oct 21, 2019

Fixes #12

Please check one:

  • New tests created for this change
  • Tests updated for this change

This PR:

  • Adds new API
  • Extends existing API, backwards-compatible
  • Introduces a breaking change
  • Fixes a bug

I think the existing fallback to console.log will work. Let's see if node 6 tests pass in CI.

@RazerM
Copy link
Contributor Author

RazerM commented Oct 21, 2019

@shellscape can you get CI working. I guess you don't have it running on a schedule so it's hard to contribute.

@shellscape
Copy link
Owner

CI is fixed. Once the conflicts are cleaned up you should be good.

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #13 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #13      +/-   ##
=========================================
- Coverage   92.43%   92.3%   -0.13%     
=========================================
  Files           4       4              
  Lines         119     117       -2     
=========================================
- Hits          110     108       -2     
  Misses          9       9
Impacted Files Coverage Δ
lib/factory/MethodFactory.js 80.95% <ø> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795e4cd...8546e94. Read the comment docs.

@RazerM
Copy link
Contributor Author

RazerM commented Feb 20, 2020

@shellscape I don't know why Travis CI didn't respond but this should be good to merge

@shellscape
Copy link
Owner

I'll check it out

@shellscape shellscape merged commit 330f6d6 into shellscape:master Apr 13, 2020
@shellscape
Copy link
Owner

@RazerM sorry this took a while to get merged. Slipped under the radar for a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log.debug uses console.log
2 participants