chore: change supported node versions #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds testing for node v11 - v14. This removes testing for node v6 and v7 because codecov breaks on these versions. This omits node v15 because appveyor doesn't seem to support this version. The nodejs org currently supports [10, 12, 14, 15]. This adds a small logging statement to the check-node-support script. Test: npm run check-node-support
nfischer
force-pushed
the
chore-test-node-versions
branch
from
1682149
to
c7ea057
Compare
nfischer
added a commit
to shelljs/shelljs
that referenced
this pull request
Oct 26, 2020
This adds testing for node v14. This removes testing for node v6 and v7 because codecov breaks on these versions. This omits node v15 because appveyor doesn't seem to support this version. The nodejs org currently supports [10, 12, 14, 15]. This makes a couple minor edits to the check-node-support script for consistency with shelljs/shx#186. Test: npm run check-node-support
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 114 114
=========================================
Hits 114 114 Continue to review full report at Codecov.
|
nfischer
added a commit
to shelljs/shelljs
that referenced
this pull request
Oct 26, 2020
This adds testing for node v14. This removes testing for node v6 and v7 because codecov breaks on these versions. This omits node v15 because appveyor doesn't seem to support this version. The nodejs org currently supports [10, 12, 14, 15]. This makes a couple minor edits to the check-node-support script for consistency with shelljs/shx#186. This bumps the shx dependency because it seems we're hitting issue #973 on node v14. Test: npm run check-node-support
nfischer
added a commit
to shelljs/shelljs
that referenced
this pull request
Oct 26, 2020
This adds testing for node v14. This removes testing for node v6 and v7 because codecov breaks on these versions. This omits node v15 because appveyor doesn't seem to support this version. The nodejs org currently supports [10, 12, 14, 15]. This makes a couple minor edits to the check-node-support script for consistency with shelljs/shx#186. This bumps the shx dependency because it seems we're hitting issue #973 on node v14. Test: npm run check-node-support
nfischer
added a commit
that referenced
this pull request
Jan 10, 2022
No change to logic. This adds back node v6 support to partially revert #186. I'm hoping that v6 support is easier now that we rely on GitHub actions for codecov. The motivation for this change is so that we can make 0.3.x patch releases if necessary.
nfischer
added a commit
that referenced
this pull request
Jan 10, 2022
No change to logic. This adds back node v6 support to partially revert #186. I'm hoping that v6 support is easier now that we rely on GitHub actions for codecov. The motivation for this change is so that we can make 0.3.x patch releases if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds testing for node v11 - v14. This removes testing for node v6
and v7 because codecov breaks on these versions. This omits node v15
because appveyor doesn't seem to support this version. The nodejs org
currently supports [10, 12, 14, 15].
This adds a small logging statement to the check-node-support script.
Test: npm run check-node-support