Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add true and false as default commands #142

Merged
merged 2 commits into from Jul 10, 2018
Merged

Conversation

nfischer
Copy link
Member

@nfischer nfischer commented Jul 4, 2018

This implements true and false as a single plugin, and adds this plugin
by default to shx.

Fixes #105
Test: automated tests
Test: manual (works as expected)

This implements true and false as a single plugin, and adds this plugin
by default to shx.

Fixes #105
Test: automated tests
Test: manual (works as expected)
@nfischer nfischer added the feat label Jul 4, 2018
@nfischer nfischer self-assigned this Jul 4, 2018
@nfischer nfischer requested a review from freitagbr July 4, 2018 22:39
Copy link
Contributor

@freitagbr freitagbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Jul 10, 2018

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #142   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      5    +1     
  Lines          82     88    +6     
=====================================
+ Hits           82     88    +6
Impacted Files Coverage Δ
src/shx.js 100% <ø> (ø) ⬆️
src/plugin-true-false.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5dc8de...ba38905. Read the comment docs.

@nfischer nfischer merged commit 84bdd3e into master Jul 10, 2018
@nfischer nfischer deleted the feat-true-false branch July 10, 2018 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants