From 9058ccf4b2fbf2b6676b5c0e1fec5f10a8cfe525 Mon Sep 17 00:00:00 2001
From: Nate Fischer <ntfschr@google.com>
Date: Sun, 2 Dec 2018 22:48:51 -0800
Subject: [PATCH] chore(node): add v10 and v11 to CI

This adds support for v10 and v11, and removes a TODO.
---
 .travis.yml                   | 2 ++
 appveyor.yml                  | 2 ++
 scripts/check-node-support.js | 2 +-
 src/exec-child.js             | 2 --
 4 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 4c7fc96d..38730b13 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,6 +5,8 @@ node_js:
   - 7
   - 8
   - 9
+  - 10
+  - 11
 
 os:
   - linux
diff --git a/appveyor.yml b/appveyor.yml
index f7490c66..c9073591 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -1,5 +1,7 @@
 environment:
   matrix:
+    - nodejs_version: '11'
+    - nodejs_version: '10'
     - nodejs_version: '9'
     - nodejs_version: '8'
     - nodejs_version: '7'
diff --git a/scripts/check-node-support.js b/scripts/check-node-support.js
index d8828b28..f6f53208 100755
--- a/scripts/check-node-support.js
+++ b/scripts/check-node-support.js
@@ -9,7 +9,7 @@ var shell = require('..');
 
 // This is the authoritative list of supported node versions.
 var MIN_NODE_VERSION = 6;
-var MAX_NODE_VERSION = 9;
+var MAX_NODE_VERSION = 11;
 
 function checkReadme(minNodeVersion) {
   var start = '<!-- start minVersion -->';
diff --git a/src/exec-child.js b/src/exec-child.js
index 999618cb..cc844e4b 100644
--- a/src/exec-child.js
+++ b/src/exec-child.js
@@ -28,8 +28,6 @@ function isMaxBufferError(err) {
     // >= v10
     // RangeError [ERR_CHILD_PROCESS_STDIO_MAXBUFFER]: stdout maxBuffer length
     // exceeded
-    // TODO(nfischer): remove when we add v10 CI (Github issue #856).
-    /* istanbul ignore next */
     return true;
   }
   return false;