refactor: don't expose tempdir in common.state #903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the cached
tempdir
value was stored incommon.state
.Unlike the other
common.state
values, this isn't immediately useful toother commands (they can just call the tempdir API). So, this moves the
cached value into
tempdir.js
.This also adds a unit test for the caching behavior, and exposes
test-only helpers to verify this behavior.
Finally, this adds a note to
common.state
that values should generallybe considered read-only, since this can be important for customized
behavior. Although, I recognize our code base has one exception to this
rule (
echo()
), we should strive to maintain this.Fixes #902
Test: Added a unit test.