Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: output npm version in travis #850

Merged
merged 1 commit into from May 11, 2018
Merged

chore: output npm version in travis #850

merged 1 commit into from May 11, 2018

Conversation

nfischer
Copy link
Member

Knowing the npm version was a huge help to debugging issue #844. For
some reason, we output this on appveyor but not on Travis. This PR fixes
that.

Knowing the `npm` version was a huge help to debugging issue #844. For
some reason, we output this on appveyor but not on Travis. This PR fixes
that.
@nfischer nfischer added the chore label May 10, 2018
@nfischer nfischer requested a review from freitagbr May 10, 2018 06:55
Copy link
Contributor

@freitagbr freitagbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why that one appveyor build is still running npm install -g npm@latest? Anyways, LGTM.

@nfischer
Copy link
Member Author

I think it's because this branch isn't rebased off the fix.

@nfischer nfischer merged commit aa9d443 into master May 11, 2018
@nfischer nfischer deleted the travis-npm-version branch May 11, 2018 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants