exec() should support node v10 (maxbuffer change) #915
Comments
nfischer
added
fix
nfischer
added a commit
that referenced
this issue
Dec 3, 2018
This explicitly checks for maxBuffer errors in exec-child.js and provides a consistent error message. This modifies the test to verify this. Although the error message is now explicit, this is not part of our API, since it's just tacked onto the end of exec's stderr. Fixes #915
nfischer
added a commit
that referenced
this issue
Dec 3, 2018
This explicitly checks for maxBuffer errors in exec-child.js and provides a consistent error message. This modifies the test to verify this. This also supports the change in Node v10, which emits this as a RangeError instead of a regular Error. Although the error message is now explicit, this is not part of our API, since it's just tacked onto the end of exec's stderr. Fixes #915
nfischer
added a commit
that referenced
this issue
Dec 3, 2018
* fix(exec): consistent error message for maxBuffer This explicitly checks for maxBuffer errors in exec-child.js and provides a consistent error message. This modifies the test to verify this. This also supports the change in Node v10, which emits this as a RangeError instead of a regular Error. Although the error message is now explicit, this is not part of our API, since it's just tacked onto the end of exec's stderr. Fixes #915 * Remove debugging log, ignore uncovered lines
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #856 (comment)
This involves rewriting a test, but also fixing
shell.exec()to expect the RangeError.The text was updated successfully, but these errors were encountered: