Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test infra: mocks and skipOnWin conflict #862

Closed
nfischer opened this issue Jun 25, 2018 · 0 comments · Fixed by #863
Closed

test infra: mocks and skipOnWin conflict #862

nfischer opened this issue Jun 25, 2018 · 0 comments · Fixed by #863
Assignees
@nfischer
Labels
test

Comments

@nfischer
Copy link
Member

I observed this while reviewing PR #861. If a test suite uses mocks.init() and also uses skipOnWin, skipOnWin should output stderr indicating the test is skipped, but the message is actually suppressed by mocks.

We can fix this by capturing process.stderr.write on startup, within utils.js, instead of using console.warn() directly.
@nfischer nfischer added the test label Jun 25, 2018
@nfischer nfischer self-assigned this Jun 25, 2018
@nfischer nfischer mentioned this issue Jun 25, 2018
Closed
nfischer added a commit that referenced this issue Jun 25, 2018
@nfischer
fix(mocks): fix conflict between mocks and skip
df4dfab 
This fixes a conflict between mocks.init() and
utils.skipOnWin/skipOnUnix. mocks.init() mocks out process.stderr.write,
which utils.js implicitly depends on.

Instead, preserve stderr.write in a local variable to avoid polluting
mocked stdio and to correctly output warning messages.

Fixes #862
Test: locally apply mocks.init() inside test/which.js
@nfischer nfischer mentioned this issue Jun 25, 2018
Merged
nfischer added a commit that referenced this issue Jun 28, 2018
@nfischer
fix(mocks): fix conflict between mocks and skip (#863)
1dd437e 
This fixes a conflict between mocks.init() and
utils.skipOnWin/skipOnUnix. mocks.init() mocks out process.stderr.write,
which utils.js implicitly depends on.

Instead, preserve stderr.write in a local variable to avoid polluting
mocked stdio and to correctly output warning messages.

Fixes #862
Test: locally apply mocks.init() inside test/which.js
@snyk-bot snyk-bot mentioned this issue Oct 27, 2019
Open
This was referenced Nov 29, 2019
Open
Open
@snyk-bot snyk-bot mentioned this issue Dec 18, 2019
Open
@snyk-bot snyk-bot mentioned this issue Mar 8, 2020
Open
This was referenced Mar 24, 2020
Merged
Merged
@snyk-bot snyk-bot mentioned this issue Apr 3, 2020
Open
This was referenced Apr 24, 2020
Open
Open
Merged
Closed
Merged
@snyk-bot snyk-bot mentioned this issue May 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfischer nfischer

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mocks): fix conflict between mocks and skip shelljs/shelljs
1 participant
@nfischer