-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
musllinux wheel missing #1996
Comments
Looking at NumPy binary wheels on PyPI, I can see that musllinux wheels are available since numpy>=1.25 and for cp39 and later. |
To be more verbose, I believe the issue here is that While
That constraint allows installing The fix is to constrain to The patch is something like this: diff --git a/pyproject.toml b/pyproject.toml
index b053dfc..b4d727f 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -28,17 +28,15 @@ classifiers = [
"Operating System :: MacOS",
"Operating System :: Microsoft :: Windows",
"Programming Language :: Python :: 3",
- "Programming Language :: Python :: 3.7",
- "Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Topic :: Scientific/Engineering :: GIS",
]
-requires-python = ">=3.7"
+requires-python = ">=3.9"
dependencies = [
- "numpy>=1.14,<2",
+ "numpy>=1.25,<2",
]
[project.optional-dependencies] |
That is, I think installing shapely would be acceptably fast on Alpine if it used the numpy wheel. |
Adding musllinux isn't too difficult to enable, as it is well-supported by cibuildwheel. Perhaps it's just the timing of the availability. It is probably best to wait for shapely 2.1, which doesn't have any planned release deadline (yet). But it could be considered for an upcoming shapely 2.0 maintenance release, if there is significant demand. |
Waiting is fine. Drop of Python <3.9 support should be handled well and announced in some way maybe. It's not an urgent thing. But musllinux support will save a lot of time and compute resources for Alpine based environments. |
Just noting that this version constraint itself is also already changed on the But also agreed that it might be rather straightforward to add musllinux wheels with cibuildwheel. Only our |
Are there now plans for 2.1? |
Expected behavior and actual behavior.
There should be a wheel for
musllinux
, to speed up CI build times significantly when using Alpine-based Python base images.Steps to reproduce the problem.
pip install shapely => Builds from source instead of using a pre-built wheel for musllinux
Operating system
Alpine Linux, x86_64
Shapely version and provenance
Until at least 2.0.3
The text was updated successfully, but these errors were encountered: