Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix versioneer configuration #1654

Merged
merged 2 commits into from Dec 6, 2022
Merged

Fix versioneer configuration #1654

merged 2 commits into from Dec 6, 2022

Conversation

sebastic
Copy link
Contributor

@sebastic sebastic commented Dec 6, 2022 •
edited

Update versioneer configuration like geopandas for which it does work in the context of package builds.

Fixes: #1653

@sebastic sebastic mentioned this pull request Dec 6, 2022
Closed
@coveralls
Copy link

coveralls commented Dec 6, 2022 •
edited

Pull Request Test Coverage Report for Build 3629992260

  • 53 of 127 (41.73%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.4%) to 87.118%
Changes Missing Coverage Covered Lines Changed/Added Lines %
shapely/_version.py 51 125 40.8%
Totals Coverage Status
Change from base Build 3608968164: -1.4%
Covered Lines: 2394
Relevant Lines: 2748
💛 - Coveralls

mwtoews
mwtoews approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@mwtoews mwtoews left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

This also reminds me to sift thru git grep -i pygeos, so I might have another PR soon (this was covered by #1649).

@jorisvandenbossche jorisvandenbossche changed the title Fix versioneer configuration. Fix versioneer configuration Dec 6, 2022
@jorisvandenbossche jorisvandenbossche merged commit a4a65be into shapely:main Dec 6, 2022
@jorisvandenbossche
Copy link
Member

Thanks @sebastic !

@sebastic sebastic deleted the versioneer branch December 7, 2022 06:37
@caspervdw caspervdw mentioned this pull request Dec 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwtoews mwtoews mwtoews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version missing in 2.0rc2
4 participants
@sebastic @coveralls @jorisvandenbossche @mwtoews