Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: restore speed of LineString(..) from numpy array of coordinates #1602

Merged
merged 3 commits into from Nov 14, 2022
Merged

PERF: restore speed of LineString(..) from numpy array of coordinates #1602

merged 3 commits into from Nov 14, 2022

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Nov 12, 2022 •
edited

Closes #1601

See #1601 (comment) for a timing with this branch

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3451045576

  • 18 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 84.799%
Totals Coverage Status
Change from base Build 3445349921: 0.05%
Covered Lines: 2198
Relevant Lines: 2592
💛 - Coveralls

@jorisvandenbossche jorisvandenbossche merged commit e027985 into shapely:main Nov 14, 2022
@jorisvandenbossche jorisvandenbossche deleted the perf-geometry-class-from-ndarray branch November 14, 2022 08:41
@jorisvandenbossche jorisvandenbossche mentioned this pull request Jan 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LineString creation is 167x slower than it needs to be
2 participants
@jorisvandenbossche @coveralls