Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Point(..) constructor change no longer allowing coordinate sequence of len > 1 #1600

Merged

Conversation

jorisvandenbossche
Copy link
Member

See #1590 (comment) for context

With shapely 1.8:

In [1]: from shapely.geometry import Point

In [2]: Point([(1, 2), (3, 4), (5, 6)]).wkt
Out[2]: 'POINT (1 2)'

One 2.x, this raises an error instead of ignoring the other coordinates. This PR adds an explicit test for this and a note in the release notes.

@coveralls
Copy link

coveralls commented Nov 11, 2022

Pull Request Test Coverage Report for Build 3459367734

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 84.791%

Totals Coverage Status
Change from base Build 3445349921: 0.04%
Covered Lines: 2191
Relevant Lines: 2584

💛 - Coveralls

docs/release/2.x.rst Outdated Show resolved Hide resolved
Co-authored-by: Casper van der Wel <caspervdw@gmail.com>
@jorisvandenbossche jorisvandenbossche merged commit bc7fa91 into shapely:main Nov 14, 2022
@jorisvandenbossche jorisvandenbossche deleted the point-constructor-change branch November 14, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants