BUG: move weakref-able implementation to base C extension type (fix PyPy) #1577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1575
I haven't yet checked if this actually fixes it on PyPy, but it's a potential fix for the issue. My understanding is that on PyPy also extension types defined in C support weakref by default, so therefore adding this manually in the subclasses as we did here is failing (https://foss.heptapod.net/pypy/pypy/-/issues/2670#note_45293)
The implementation of adding a
weakreflist
slot is mimicked from numpy (how they do that for the ndarray extension type)