Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error when strange data is received #32

Merged
merged 9 commits into from Oct 21, 2022
Merged

Return error when strange data is received #32

merged 9 commits into from Oct 21, 2022

Conversation

shamaton
Copy link
Owner

@shamaton shamaton commented Oct 20, 2022

#31

@shamaton shamaton added the bug Something isn't working label Oct 20, 2022
@shamaton shamaton self-assigned this Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 81.29% // Head: 76.73% // Decreases project coverage by -4.56% ⚠️

Coverage data is based on head (04898e6) compared to base (a5e4750).
Patch coverage: 37.31% of modified lines in pull request are covered.

❗ Current head 04898e6 differs from pull request most recent head c4edbe5. Consider uploading reports for the commit c4edbe5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   81.29%   76.73%   -4.57%     
==========================================
  Files          38       38              
  Lines        2416     2600     +184     
==========================================
+ Hits         1964     1995      +31     
- Misses        284      365      +81     
- Partials      168      240      +72     
Impacted Files Coverage Δ
internal/decoding/uint.go 38.57% <21.21%> (-17.68%) ⬇️
internal/decoding/struct.go 59.77% <27.41%> (-18.33%) ⬇️
internal/decoding/decoding.go 74.38% <28.57%> (-1.79%) ⬇️
internal/decoding/bin.go 68.96% <33.33%> (-26.28%) ⬇️
internal/decoding/complex.go 60.00% <33.33%> (-40.00%) ⬇️
internal/decoding/float.go 35.08% <33.33%> (-7.47%) ⬇️
internal/decoding/int.go 64.63% <33.33%> (-23.70%) ⬇️
internal/decoding/slice.go 70.86% <33.33%> (-3.79%) ⬇️
internal/decoding/string.go 72.97% <42.85%> (-20.58%) ⬇️
internal/decoding/map.go 67.01% <50.00%> (-0.65%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shamaton shamaton merged commit 01ee57d into master Oct 21, 2022
@shamaton shamaton deleted the case_crash branch October 21, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant