Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose original 'done' function #60

Open
modax opened this issue Jun 8, 2015 · 2 comments
Open

Expose original 'done' function #60

modax opened this issue Jun 8, 2015 · 2 comments

Comments

@modax
Copy link

modax commented Jun 8, 2015

Hello,

I need to call browser-sync in 'done' callback and I would like to do this in addition to the original 'done' callback which performs quite a lot useful stuff. However, current API leaves me no other choice but to replace original done callback without a way to do a "super" call. It would be great if original done function (starting at https://github.com/shama/gulp-webpack/blob/master/index.js#L30) would either be publicly exposed or passed to the overriding 'done' as third parameter.

@shama
Copy link
Owner

shama commented Jun 8, 2015

I'd accept a patch that exposed it as a separate method.

@modax
Copy link
Author

modax commented Jun 9, 2015

Sure. See #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants