Incomplete sample application installation instructions

[alexeyr]

Environment

1. Ruby version: 3.0.2 (eventually)
2. Rails version: 7.0.0
3. Webpacker version: 6.1.1
4. React on Rails version: 13.0.2

Expected behavior

Following spec/dummy/README.md should install and start the sample application.

Actual behavior

1. The expected ruby version should be specified either in README or .ruby-version.

   1. 3.1.1 failed to start due to Rails cashes with Ruby 3.1.0 release rails/rails#43998 (even though it's a warning), fixed in Rails 7.0.2.
   2. 3.0.3 failed to start due to iseq.rb:13 to_binary: wrong argument type false (expected Symbol) Shopify/bootsnap#378, fixed in bootsnap 1.9.2/3.
   3. 3.0.2 works, but rake test doesn't due to Ruby 3.0.1 support pry/pry-doc#113, fixed in pry-doc 1.2.0.

2. I found additional steps to be necessary:

   1. bundle install in both root and spec/dummy.
   2. yarn rescript:build before foreman because it doesn't build the dependencies. In my accompanying PR this is a separate step, but maybe a better way would be to add -with-deps in

      react_on_rails/spec/dummy/package.json

      Line 81 in 0e96cf8

      "build:rescript:dev": "rescript build -w"

      ?

3. Procfile.spec (mentioned under "Creating Assets for Tests") currently doesn't exist.

4. bundle exec rspec both in root and spec/dummy produces some failures in addition to "ruby/3.0.2 isn't supported by this pry-doc version" from 1.3, but it could be because of the missing assets or some other problem with my setup.

5. After posting this, I found more information on setup in CONTRIBUTING.md. It should probably be linked from the README instead of duplicating information.

[justin808]

@alexeyr AWESOME work! Keep going!

[jasonfb]

hey @alexeyr -- I think I'm gonna work on this a little this weekend if you want to pair up. not sure if you were building a jsbundling app or an importmap app under Rails 7 (you don't specify), but I am going for a solution using esbuild through JSBundling.

if you have an example app from the attempts above, I will pull it and take a look if that's helpful.

as well, from what I understand there's a CSS collision if you use both JSBundling and CSSbundling, so I'm not actually sure how to get esbuild to compile the React CSS and also how to get SCSS to compile the application CSS. (that's where I'm stuck). I will start a separate issue this weekend with my own notes.

[alexeyr-c]

@jasonfb Sorry, I won't be able to. And anyway, my changes were basically limited to documentation in #1443, I didn't even start updating other dependency versions.

[jasonfb]

@alexeyr-c -- ok very good I think I'm a different path anyway.

[Judahmeek]

@ahangarha if your recent work resolved this issue, then please close this.

[ahangarha]

@Judahmeek Not actually. I couldn't make it work. I get a never-ended loading page, with no error or any helpful message in the terminal.

[Judahmeek]

I believe #1443 resolved most of this.