Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nix version in tests #3265

Open
stevenengler opened this issue Jan 1, 2024 · 0 comments
Open

Upgrade nix version in tests #3265

stevenengler opened this issue Jan 1, 2024 · 0 comments
Labels
Component: Build Build/install tools and dependencies Type: Maintenance Refactoring, cleanup, documenation, or process improvements

Comments

@stevenengler
Copy link
Contributor

stevenengler commented Jan 1, 2024

Version 1.27.0 of nix changed many (but not all) functions to take AsFd types instead of RawFd (an integer). Upgrading the tests is painful where we use integer file handles everywhere.

This version of nix also changes the epoll API, so we would also need to update tests that use the old API. But it might make more sense to not use nix for these tests, and use something closer to the actual syscall API instead.

If we're going to need to update a lot of tests, it might be worth changing them to rustix or linux-api instead.

@stevenengler stevenengler added Type: Maintenance Refactoring, cleanup, documenation, or process improvements Component: Build Build/install tools and dependencies labels Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build Build/install tools and dependencies Type: Maintenance Refactoring, cleanup, documenation, or process improvements
Projects
None yet
Development

No branches or pull requests

1 participant