Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow doesn't build in directories with whitespace, quotes, colons, or semicolons #3180

Open
stevenengler opened this issue Sep 26, 2023 · 0 comments
Labels
Type: Bug Error or flaw producing unexpected results

Comments

@stevenengler
Copy link
Contributor

stevenengler commented Sep 26, 2023

If you build shadow in a directory path containing any of the following characters (and maybe others), shadow will fail to build:

  • space
  • tab
  • linebreak (any of '\r', '\n', '\r\n')
  • single quote
  • double quote
  • colon
  • semicolon

We should fix this, at least for reasonable characters like spaces and colons.

On the other hand, shadow can't be run if the binary (and therefore the preload libs) exists in a directory path containing spaces or colons since these are path separators for LD_PRELOAD. But even if shadow can't run in these directories, it doesn't mean it should fail to build in these directories with confusing error messages.

@stevenengler stevenengler added the Type: Bug Error or flaw producing unexpected results label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Error or flaw producing unexpected results
Projects
None yet
Development

No branches or pull requests

1 participant