Allow to use __caching_id__ rather than __repr__ as an object caching key #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… key This allows users to implement __caching_id__ as a class method to override the default `repr` usage that does not suit all uses cases.
1 similar comment
| @@ -71,6 +71,14 @@ def get_arg_default(f, position): | |||
| return arg_def if arg_def != inspect.Parameter.empty else None | |||
|
|
|||
|
|
|||
| def get_id_func(obj): | |||
There was a problem hiding this comment.
Why this separate function is needed here? As i see you only use this value within get_id.
There was a problem hiding this comment.
For future reuse and ease readability?
There was a problem hiding this comment.
I simply canʼt think of a use case when you need the id generating function but not the ID. And this way you add an unnecessary function call to a oneliner with no significant improvement on readability. How about something like this?
def get_id(obj):
id_func = getattr(obj, '__caching_id__', repr)
return id_func(obj)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to implement caching_id as a class method to override the
default
reprusage that does not suit all uses cases.