RedisCache now supports function as a key_prefix #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
|
I can see that Travis is complaining about failed tests for pypy but those are |
sh4nks
requested changes
May 19, 2019
| @@ -226,14 +226,14 @@ def make_cache(self, request): | |||
| else: | |||
| host = redis.Redis() | |||
|
|
|||
| c = backends.RedisCache(host=host, key_prefix="werkzeug-test-case:") | |||
| c = backends.RedisCache(host=host, key_prefix=lambda: "werkzeug-test-case:") | |||
There was a problem hiding this comment.
Please add another test case which tests the key_prefix as a function instead of changing this test case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quite useful to use a function, instead of a string, as the
key_prefix. This is especially useful when we want the cache to be unique based on GET query parameters. For more details, please see https://stackoverflow.com/questions/14228985/what-does-key-prefix-do-for-flask-cache.