New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce package size #11
Comments
This patch: - excludes `mozilla_webidls.zip` from the deployed package; - upgrades lalrpop-* to 0.14.0, which has smaller files.
Apparently, I made a mistake and this doesn't remove all the files I thought it would. Blocked by lalrpop/lalrpop#333. Also, for some reason, That one is blocked by lalrpop/lalrpop#280. |
Are you sure |
I believe #13 fixes the cause of |
I'm going to keep this open until lalrpop/lalrpop#333 has been dealt with. |
Ok, at least a new version of lalrpop has just landed (0.15.0), which includes lalrpop/lalrpop#295. That should take care of some of the files. |
I'm currently trying to get a new version out, but there's a problem with the |
Lalrpop is just issued a fixed version. @sgodwincs Could you give it a try? Barring any accident, this is the last blocker for https://bugzilla.mozilla.org/show_bug.cgi?id=1437004, so I'm eager to land it :) |
@Yoric Version 0.6.0 has been released. The only change you should have to make is that the Let me know if there are anymore problems, I'm going to close this for now. |
As far as I can tell, this does the trick. Thanks! |
... and the problem seems to reappear with 0.7.0 :/ Investigating |
I'm trying to land as part of Firefox a package that depends on webidl-rs. That's unfortunately not possible because of the following files:
It would be great if we could find a way to get rid of these files.
For mozilla_webidl.zip and grammar.rs, I believe it's just a matter of adding an
exclude
in Cargo.toml. For lalrpop-*, I believe that more recent versions don't contain such huge files anymore.The text was updated successfully, but these errors were encountered: