Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider mode 3 can cross by keyboard if step is below 1 #93

Open
GabrielKatz opened this issue Sep 6, 2019 · 1 comment
Open

Slider mode 3 can cross by keyboard if step is below 1 #93

GabrielKatz opened this issue Sep 6, 2019 · 1 comment

Comments

@GabrielKatz
Copy link

GabrielKatz commented Sep 6, 2019

Problem or feature description:

If the step is below 1 and not a number that has an exact floating point representation eg. 0.5 or 0.25 (for example, 0.1), then a slider can be moved passed another by keyboard.

Steps to reproduce (for problems):

  • create a slider with these parameters:
<Slider mode={3} step={0.1} domain={[0,100]} values={[0, 10.5]}>
  • Move left slider with mouse first
  • try to move left slider past right slider by keyboard

Versions (for problems):

React-Compound-Slider:
v2.2.0

React:
16.8.6

Browser:
Chrome 76

Operating System:
Windows 10

@sghall
Copy link
Owner

sghall commented Sep 10, 2019

Hi there. Interesting. I'll have to take a look at this. If anyone wants to do a PR on this issue please let me know. I probably won't look at this until the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants